Thanks Jeff, Acked, I will add it to v5. Warm Regards, PK On Wed, Jun 19, 2024 at 11:48 PM Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote: > > On 6/17/24 21:27, Pavitrakumar M wrote: > > Signed-off-by: shwetar <shwetar@xxxxxxxxxxxxxxx> > > Signed-off-by: Pavitrakumar M <pavitrakumarm@xxxxxxxxxxxxxxx> > > Acked-by: Ruud Derwig <Ruud.Derwig@xxxxxxxxxxxx> > > --- > > drivers/crypto/dwc-spacc/spacc_core.c | 1241 ++++++++++++++++++++ > > drivers/crypto/dwc-spacc/spacc_core.h | 826 +++++++++++++ > > drivers/crypto/dwc-spacc/spacc_device.c | 339 ++++++ > > drivers/crypto/dwc-spacc/spacc_device.h | 236 ++++ > > drivers/crypto/dwc-spacc/spacc_hal.c | 367 ++++++ > > drivers/crypto/dwc-spacc/spacc_hal.h | 113 ++ > > drivers/crypto/dwc-spacc/spacc_interrupt.c | 316 +++++ > > drivers/crypto/dwc-spacc/spacc_manager.c | 650 ++++++++++ > > drivers/crypto/dwc-spacc/spacc_skcipher.c | 715 +++++++++++ > > 9 files changed, 4803 insertions(+) > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.h > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.h > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.h > > create mode 100644 drivers/crypto/dwc-spacc/spacc_interrupt.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_manager.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_skcipher.c > > > ... > > > +module_platform_driver(spacc_driver); > > + > > +MODULE_LICENSE("GPL"); > > +MODULE_AUTHOR("Synopsys, Inc."); > > Missing MODULE_DESCRIPTION() > This will cause a warning with make W=1 > >