On Wed, Jun 05, 2024 at 11:03:00PM +0200, Thomas Gleixner wrote: > Jason! Thomas! > Can you please split the required defines into a seperate header > preferrably in include/vdso/ and include that from crypto/chacha.h Sure. It only actually uses two straight forward constants from there. > > + u32 key[CHACHA_KEY_SIZE / sizeof(u32)]; > > CHACHA_STATE_WORDS ? Nah, that's for CHACHA_BLOCK_SIZE / sizeof(u32), but here is CHACHA_KEY_SIZE. > > > + }; > > + u8 batch_key[CHACHA_BLOCK_SIZE * 2]; > > What does the u8 buy here over a simple unsigned int? > > > + bool in_use; It means that the structure can be more compact, because `pos` and the `in_use` boolean will be closer together. > > diff --git a/include/vdso/types.h b/include/vdso/types.h > > new file mode 100644 > > index 000000000000..ce131463aeff > > --- /dev/null > > +++ b/include/vdso/types.h > > @@ -0,0 +1,35 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > Why does this need an extra header when it's clearly getrandom specific? > Please put this into getrandom.h
