On Fri, 7 Jun 2024 18:30:24 +0800
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Jun 05, 2024 at 06:18:49PM +0200, Marek Behún wrote:
> >
> > +static int omnia_trng_read(struct hwrng *rng, void *data, size_t max, bool wait)
> > +{
> > + struct omnia_mcu *mcu = (struct omnia_mcu *)rng->priv;
>
> Please don't cast rng->priv in this manner. Please take a look at
> drivers/char/hw_random/bcm2835-rng.c for how it should be done.
>
> Thanks,
THX, prepared for next version.
