On 5/30/24 01:08, Jarkko Sakkinen wrote:
On Thu May 30, 2024 at 2:08 AM EEST, Stefan Berger wrote:Simplify two functions that were using temporary byte arrays for converting too-short input byte arrays to digits. Use ecc_digits_from_bytes since this function can now handle an input byte array that provides less bytes than what a coordinate of a curve requires - the function provides zeros for the missing (leading) bytes. See: c6ab5c915da4 ("crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes") Regards, Stefan Stefan Berger (2): crypto: ecdsa - Use ecc_digits_from_bytes to create hash digits array crypto: ecdsa - Use ecc_digits_from_bytes to convert signature crypto/ecdsa.c | 29 ++++++----------------------- 1 file changed, 6 insertions(+), 23 deletions(-)BTW, would it make sense split ecdsa signature encoding to its own patch in my next patch set version and name it ecdsa_* style and put it to ecdsa.c?
I would only put it into ecdsa.c if functions inside this file (can) make use of it, otherwise leave it in your file.
Just asking this because the part should be the same same for any ECDSA signature. It must scale also to all NIST variants before my patch set can land. BR, Jarkko
