Hi Herbert,
Yes, we have enabled the CRYPTO_MANAGER_EXTRA_TESTS and
all tests are passing with the default 100 iterations. We bumped
the iterations to 500 and verified that as well for all our algos.
About the export function, yes its hash state that's present inside
"spacc_crypto_ctx".
which also holds the intermediate digest. The SPAcc IP supports
multiple hashes,
ciphers and aeads. We use the same context structure across all algos. Do let me
know if that needs to be modified.
Warm regards,
PK
On Fri, May 3, 2024 at 3:59 PM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Apr 26, 2024 at 09:55:40AM +0530, Pavitrakumar M wrote:
> .
> > +static int spacc_hash_export(struct ahash_request *req, void *out)
> > +{
> > + const struct spacc_crypto_reqctx *ctx = ahash_request_ctx(req);
> > +
> > + memcpy(out, ctx, sizeof(*ctx));
> > +
> > + return 0;
> > +}
>
> Did you test this with CRYPTO_MANAGER_EXTRA_TESTS enabled?
>
> When a hash exports its state, it's meant to write out the actual
> partial hash state, not a bunch of kernel pointers.
>
> Cheers,
> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
