Re: [PATCH v3 3/7] Add SPAcc ahash support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 26, 2024 at 09:55:40AM +0530, Pavitrakumar M wrote:
.
> +static int spacc_hash_export(struct ahash_request *req, void *out)
> +{
> +	const struct spacc_crypto_reqctx *ctx = ahash_request_ctx(req);
> +
> +	memcpy(out, ctx, sizeof(*ctx));
> +
> +	return 0;
> +}

Did you test this with CRYPTO_MANAGER_EXTRA_TESTS enabled?

When a hash exports its state, it's meant to write out the actual
partial hash state, not a bunch of kernel pointers.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux