Hi Easwar,
We have broken the main driver patch into 4 patches as shown below
LOC PATCH
4979 - 0001-Add-SPAcc-Skcipher-support.patch
1470 - 0002-Enable-SPAcc-AUTODETECT.patch
1283 - 0003-Add-SPAcc-ahash-support.patch
1333 - 0004-Add-SPAcc-aead-support.patch
138 - 0005-Add-SPAcc-Kconfig-and-Makefile.patch
33 - 0006-Add-SPAcc-node-zynqmp-dts.patch
60 - 0007-Enable-Driver-compilation-in-crypto-Kconfig-and-Make.patch
I have NOT broken the first patch into a "core" and a "skcipher"
patch because the core patch
will throw warnings for "Functions defined but not used" if applied
standalone during kernel CI/CD.
No compilation errors, so nothing is going to break; but there will
be warnings.
Core patch provides the infrastructure that cipher, hash and aead modules use.
I will check with the kernel CI/CD team regarding this but do let me
know if you have any
details related to this.
If thats not a problem for kernel CI/CD, i.e. if the kernel CI/CD is
run only after all patches
are applied in order, then I can break up the first patch further
into two. So the core patch
will mostly be around 4k Lines of Code.
Do let me know.
Warm regards,
PK
On Thu, Apr 18, 2024 at 10:43 PM Easwar Hariharan
<eahariha@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On 4/17/2024 8:54 PM, Pavitrakumar Managutte wrote:
> > Hi Easwar,
> > The driver has legacy code which was taking time in splitting, so
> > pushed the v2
> > patch without splitting. I am splitting AEAD, Hash and Cipher module code, which
> > would be easier to review instead of a single 9k loc patch.
> >
> > I do appreciate your valuable time and feedback on the patches.
> >
> > Warm regards,
> > PK
> >
>
> Thanks, I'll wait for that v3 to continue review.
>
> - Easwar
>
