Hi Easwar, The driver has legacy code which was taking time in splitting, so pushed the v2 patch without splitting. I am splitting AEAD, Hash and Cipher module code, which would be easier to review instead of a single 9k loc patch. I do appreciate your valuable time and feedback on the patches. Warm regards, PK On Wed, Apr 17, 2024 at 11:08 PM Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx> wrote: > > On 4/11/2024 8:53 PM, Pavitrakumar M wrote: > > Signed-off-by: shwetar <shwetar@xxxxxxxxxxxxxxx> > > Signed-off-by: Pavitrakumar M <pavitrakumarm@xxxxxxxxxxxxxxx> > > Acked-by: Ruud Derwig <Ruud.Derwig@xxxxxxxxxxxx> > > --- > > drivers/crypto/dwc-spacc/spacc_aead.c | 1317 +++++++++ > > drivers/crypto/dwc-spacc/spacc_ahash.c | 1171 ++++++++ > > drivers/crypto/dwc-spacc/spacc_core.c | 2910 ++++++++++++++++++++ > > drivers/crypto/dwc-spacc/spacc_core.h | 839 ++++++ > > drivers/crypto/dwc-spacc/spacc_device.c | 324 +++ > > drivers/crypto/dwc-spacc/spacc_device.h | 236 ++ > > drivers/crypto/dwc-spacc/spacc_hal.c | 365 +++ > > drivers/crypto/dwc-spacc/spacc_hal.h | 113 + > > drivers/crypto/dwc-spacc/spacc_interrupt.c | 204 ++ > > drivers/crypto/dwc-spacc/spacc_manager.c | 670 +++++ > > drivers/crypto/dwc-spacc/spacc_skcipher.c | 720 +++++ > > 11 files changed, 8869 insertions(+) > > create mode 100644 drivers/crypto/dwc-spacc/spacc_aead.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_ahash.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.h > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.h > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.h > > create mode 100644 drivers/crypto/dwc-spacc/spacc_interrupt.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_manager.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_skcipher.c > > > > > Sorry, cannot feasibly review ~9000 lines between my other responsibilities. As mentioned in v1, > make it easier on the folks who're giving their time by splitting up the series. > > Thanks, > Easwar >