On Tue, Apr 16, 2024 at 08:39:28AM -0500, Joachim Vandersmissen wrote: > > I did consider that initially, but I was unsure if this was the right path. > From a conceptual standpoint, this module doesn't need the RSA (or ECDSA) > functionality. If the algorithm is not present, it would be perfectly valid > for the module to do nothing. However, I'm not opposed to removing the > current check and adding the select to the Kconfig. > > If I add a `select CRYPTO_RSA` to FIPS_SIGNATURE_SELFTEST, do you think I > should do something similar for ECDSA as well (considering the other patch > in this series)? I think we should split the data out into individual files, leaving only the test code in selftest.c. Each individual file could then invoke the test function directly on its data. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
