On Thu, Nov 23, 2023 at 01:36:34AM +0100, Christoph Müllner wrote: > On Thu, Nov 23, 2023 at 12:43 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > > > On Wed, Nov 22, 2023 at 03:58:17PM +0800, Jerry Shih wrote: > > > On Nov 22, 2023, at 07:51, Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > > > On Wed, Nov 01, 2023 at 09:03:33PM -0700, Eric Biggers wrote: > > > >> > > > >> It would be nice to use a real assembler, so that people won't have to worry > > > >> about potential mistakes or inconsistencies in the perl-based "assembler". Also > > > >> keep in mind that if we allow people to compile this code without the real > > > >> assembler support from the beginning, it might end up staying that way for quite > > > >> a while in order to avoid breaking the build for people. > > > >> > > > >> Ultimately it's up to you though; I think that you and others who have been > > > >> working on RISC-V crypto can make the best decision about what to do here. I > > > >> also don't want this patchset to be delayed waiting for other projects, so maybe > > > >> that indeed means the perl-based "assembler" needs to be used for now. > > > > > > > > Just wanted to bump up this discussion again. In binutils, the vector crypto > > > > v1.0.0 support was released 4 months ago in 2.41. See the NEWS file at > > > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob_plain;f=binutils/NEWS;hb=refs/heads/binutils-2_41-branch > > > > > > > > * The RISC-V port now supports the following new standard extensions: > > > > - Zicond (conditional zero instructions) > > > > - Zfa (additional floating-point instructions) > > > > - Zvbb, Zvbc, Zvkg, Zvkned, Zvknh[ab], Zvksed, Zvksh, Zvkn, Zvknc, Zvkng, > > > > Zvks, Zvksc, Zvkg, Zvkt (vector crypto instructions) > > > > > > > > That's every extension listed in the vector crypto v1.0.0 specification > > > > (https://github.com/riscv/riscv-crypto/releases/download/v1.0.0/riscv-crypto-spec-vector.pdf). > > > > > > It doesn't fit all v1.0 spec. > > > The `Zvkb` is missed in binutils. It's the subset of `Zvbb`. We needs some extra > > > works if user just try to use `Zvkb`. > > > https://github.com/riscv/riscv-crypto/blob/main/doc/vector/riscv-crypto-vector-zvkb.adoc > > > Some crypto algorithms are already checking for `Zvkb` instead of `Zvbb`. > > > > Yeah, that's unfortunate that Zvkb got missed in binutils. However, since all > > Zvkb instructions are part of Zvbb, which is supported, assembling Zvkb > > instructions should still work --- right? > > Not forgotten, but the Zvkb extension did not exist when the patchset > was merged. > RISC-V extension support is typically merged when specifications are "frozen". > This means a high bar for changes, but they are possible until the > spec is ratified. > Often nothing is changed until ratification, but here Zvkb has been > (re-)introduced. > > I was not aware of this untils I read this email, so I just wrote a > patch that fills the gap: > https://sourceware.org/pipermail/binutils/2023-November/130762.html > Thanks Christoph! That binutils patch looks good to me. - Eric
