On 10/08/2023 09:22, Tudor Ambarus wrote: > > > On 8/10/23 06:38, Varshini.Rajendran@xxxxxxxxxxxxx wrote: >>> On 7/28/23 11:24, Varshini Rajendran wrote: >>>> Add DT bindings for atmel TDES. >>> NACK. The atmel crypto drivers check the version at runtime and >>> fill a capabilities structure based on the version identified. >>> There's a single compatible regardless of the version of the IP >>> used until now, why do you want to change it? >>> >> Hi Tudor, > > Hi, > >> >> I am aware that there is no change in the crypto IP used. This patch is >> to add a SoC specific compatible as expected by writing-bindings >> guideline. Maybe a bit more explanation in the commit description might >> do the trick. >> > > So you add a compatible that will never be used just to comply with > the writing bindings guideline? How do you know that it is never going to be used? The guideline asks for this on purpose, so any future quirks or incompatibilities can be easily addressed. Best regards, Krzysztof
