On 28/07/23 4:47 pm, Tudor Ambarus wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi, > > On 7/28/23 11:24, Varshini Rajendran wrote: >> Add DT bindings for atmel TDES. > > NACK. The atmel crypto drivers check the version at runtime and > fill a capabilities structure based on the version identified. > There's a single compatible regardless of the version of the IP > used until now, why do you want to change it? > Hi Tudor, I am aware that there is no change in the crypto IP used. This patch is to add a SoC specific compatible as expected by writing-bindings guideline. Maybe a bit more explanation in the commit description might do the trick. > Please describe what motivated you to write this patch. Some people > can't take seriously a patch if it misses a proper description and > they just ignore it. Maybe it is worth re-reading: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes > > Cheers, > ta >> >> Signed-off-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml >> index 3d6ed24b1b00..6a441f79efea 100644 >> --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml >> +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml >> @@ -12,7 +12,11 @@ maintainers: >> >> properties: >> compatible: >> - const: atmel,at91sam9g46-tdes >> + oneOf: >> + - const: atmel,at91sam9g46-tdes >> + - items: >> + - const: microchip,sam9x7-tdes >> + - const: atmel,at91sam9g46-tdes >> >> reg: >> maxItems: 1 -- Thanks and Regards, Varshini Rajendran.
