On Mon, Apr 24, 2023 at 02:47:23PM -0400, Danny Tsen wrote: > > +static int chacha_p10_stream_xor(struct skcipher_request *req, > + const struct chacha_ctx *ctx, const u8 *iv) > +{ > + struct skcipher_walk walk; > + u32 state[16]; > + int err; > + > + err = skcipher_walk_virt(&walk, req, false); > + if (err) > + return err; > + > + chacha_init_generic(state, ctx->key, iv); > + > + while (walk.nbytes > 0) { > + unsigned int nbytes = walk.nbytes; > + > + if (nbytes < walk.total) > + nbytes = rounddown(nbytes, walk.stride); > + > + if (!static_branch_likely(&have_p10) || You don't need the static branch in the Crypto API code since the registration is already conditional. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt