On Tue, Apr 25, 2023 at 01:37:22PM +0800, Herbert Xu wrote: > On Mon, Apr 24, 2023 at 02:47:23PM -0400, Danny Tsen wrote: > > > > +static int __init chacha_p10_init(void) > > +{ > > + static_branch_enable(&have_p10); > > + > > + return IS_REACHABLE(CONFIG_CRYPTO_SKCIPHER) ? > > + crypto_register_skciphers(algs, ARRAY_SIZE(algs)) : 0; > > What is this for? The usual way is to select CRYPTO_SKCIPHER > rather than have a mysterious failure at run-time. Nevermind, I see that you also have non-Crypto API code in there. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt