On Mon, Feb 20, 2023 at 08:28:05AM +0100, Ard Biesheuvel wrote: > > We would still not have any in-tree users of cfb(aes) or any other > cfb(*), so in that sense, yes. > > However, skciphers can be called from user space, and we also rely on > this template for the extended testing of the various cfb() hardware > implementations that we have in the tree. > > So the answer is no, I suppose. I would like to simplify it a bit, > though - it is a bit more complicated than it needs to be. Could we hold onto this for a little bit? I'd like to finally remove crypto_cipher, and in doing so I will add a virtual address interface (i.e., not sg) to skcipher like we do with scomp and shash. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt