On Fri, Feb 17, 2023 at 03:43:48PM +0100, Ard Biesheuvel wrote: > Implement AES in CFB mode using the existing, mostly constant-time > generic AES library implementation. This will be used by the TPM code > to encrypt communications with TPM hardware, which is often a discrete > component connected using sniffable wires or traces. > > While a CFB template does exist, using a skcipher is a major pain for > non-performance critical synchronous crypto where the algorithm is known > at compile time and the data is in contiguous buffers with valid kernel > virtual addresses. > > Tested-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > Reviewed-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > Link: https://lore.kernel.org/all/20230216201410.15010-1-James.Bottomley@xxxxxxxxxxxxxxxxxxxxx/ > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx> > --- > v1 was sent out by James and is archived at the URL above > > v2: > - add test cases and kerneldoc comments > - add memzero_explicit() calls to wipe the keystream buffers > - add module exports > - add James's Tb/Rb > > include/crypto/aes.h | 5 + > lib/crypto/Kconfig | 5 + > lib/crypto/Makefile | 3 + > lib/crypto/aescfb.c | 257 ++++++++++++++++++++ > 4 files changed, 270 insertions(+) Could we remove the crypto/cfb.c implementation after this work is complete? Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
