On Thu, Mar 09, 2023 at 11:04:18AM +0000, Giovanni Cabiddu wrote: > > You are right. Thanks for spotting this. > When reviewing it I mixed up the cmp_err and xlt_err with the status which > is a u8. In general s8/u8 should only be used when you are directly reading or writing from hardware. Once the value has entered your driver, you should use int/unsigned int to deal with them. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
