Re: [PATCH] crypto: qat - change size of status variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 09, 2023 at 11:33:06AM +0000, Meadhbh Fitzpatrick wrote:
> 
> diff --git a/drivers/crypto/qat/qat_common/qat_comp_algs.c b/drivers/crypto/qat/qat_common/qat_comp_algs.c
> index b533984906ec..726b71d2a4a8 100644
> --- a/drivers/crypto/qat/qat_common/qat_comp_algs.c
> +++ b/drivers/crypto/qat/qat_common/qat_comp_algs.c
> @@ -183,7 +183,7 @@ static void qat_comp_generic_callback(struct qat_compression_req *qat_req,
>  	int consumed, produced;
>  	s8 cmp_err, xlt_err;
>  	int res = -EBADMSG;
> -	int status;
> +	s8 status;

Sorry, but this makes no sense.  Why are these s8's to begin
with? It doesn't look like you even allow negative values.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux