On 2/11/23 04:19, Dave Hansen wrote: Hi Dave, Thank you so much for the review! > On 2/10/23 10:15, Taehee Yoo wrote: >> vpbroadcastb and vpbroadcastd are not AVX instructions. >> But the aria-avx assembly code contains these instructions. >> So, kernel panic will occur if the aria-avx works on AVX2 unsupported >> CPU. > ... >> My CPU supports AVX2. >> So, I disabled AVX2 with QEMU. >> In the VM, lscpu doesn't show AVX2, but kernel panic didn't occur. >> Therefore, I couldn't reproduce kernel panic. >> I will really appreciate it if someone test this patch. > > So, someone reported this issue and you _think_ you know what went > wrong. But, you can't reproduce the issue so it sounds like you're not > confident if this is the right fix or if you are fixing the right > problem in the first place. > > We can certainly apply obvious fixes, but it would be *really* nice if > you could try a bit harder to reproduce this. Yes, you're right. I'm so sorry for this careless testing. I think I didn't use enough time for making the reproducer environment. I will try to make a proper environment for this work. Thank you so much! Taehee Yoo
