Re: [PATCH] crypto: x86/aria-avx - fix using avx2 instructions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/11/23 04:08, Elliott, Robert (Servers) wrote:

Hi Elliott,
Thank you so much for your review!

>> Unfortunately, this change reduces performance by about 5%.
>
> The driver could continue to use functions with AVX2 instructions
> if AVX2 is supported, and fallback to functions using only
> AVX instructions if not (assuming AVX is supported).
>

If CPU supports AVX2, ARIA-AVX2 driver will be worked and it is faster.
But, currently AVX driver requires 16 blocks and AVX2 driver requires 32 blocks. So, input block size is less than 32, AVX driver is worked even if cpu supports AVX2. I think the best solution is to make AVX, AVX2, and AVX512 drivers support various blocks. If so, we can use the best performance of ARIA algorithm regardless of input block size.
As far as I know, SM4 driver already supports it.
So, I think it would be better for ARIA follows this strategy instead of supporting AVX2 instruction in the ARIA-AVX.

Thank you so much!
Taehee Yoo



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux