Hi Herbert,
On 1/30/23 5:01 PM, Herbert Xu wrote:
On Mon, Jan 30, 2023 at 04:15:33PM +0800, Herbert Xu wrote:
Actually I think there is a serious bug here. If you're doing an
empty message, you must not call skcipher_walk_done as that may
then free random uninitialised stack memory.
Hah, I had forgotten that this thread started with your patch
to fix this exact bug :)
Could you confirm that you did copy this from ccm?
It would be nice if you could rewrite your loop in a form similar
to my patch to ccm.
Thanks,
These codes are copied from gcm and ccm at the same time. I am not sure
which has more components, but I will rewrite the gcm and ccm encryption
loop of sm4 as soon as possible.
Cheers,
Tianjia
