Re: [PATCH] crypto: atmel-i2c: Drop unused id parameter from atmel_i2c_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 31.01.2023 10:13, Uwe Kleine-König wrote:
id is unused in atmel_i2c_probe() and the callers have extra efforts to
determine the right parameter. So drop the parameter simplifying both
atmel_i2c_probe() and its callers.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>

thanks!

---
Hello,

just found a nice optimisation while grepping for something else in the
tree ...

Best regards
Uwe

  drivers/crypto/atmel-ecc.c     | 3 +--
  drivers/crypto/atmel-i2c.c     | 2 +-
  drivers/crypto/atmel-i2c.h     | 2 +-
  drivers/crypto/atmel-sha204a.c | 3 +--
  4 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index 12205e2b53b4..aac64b555204 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -313,11 +313,10 @@ static struct kpp_alg atmel_ecdh_nist_p256 = {
static int atmel_ecc_probe(struct i2c_client *client)
  {
-	const struct i2c_device_id *id = i2c_client_get_device_id(client);
  	struct atmel_i2c_client_priv *i2c_priv;
  	int ret;
- ret = atmel_i2c_probe(client, id);
+	ret = atmel_i2c_probe(client);
  	if (ret)
  		return ret;
diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
index 66e27f71e37e..83a9093eff25 100644
--- a/drivers/crypto/atmel-i2c.c
+++ b/drivers/crypto/atmel-i2c.c
@@ -324,7 +324,7 @@ static int device_sanity_check(struct i2c_client *client)
  	return ret;
  }
-int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id)
+int atmel_i2c_probe(struct i2c_client *client)
  {
  	struct atmel_i2c_client_priv *i2c_priv;
  	struct device *dev = &client->dev;
diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h
index c1fdc04eac07..c0bd429ee2c7 100644
--- a/drivers/crypto/atmel-i2c.h
+++ b/drivers/crypto/atmel-i2c.h
@@ -167,7 +167,7 @@ struct atmel_i2c_work_data {
  	struct atmel_i2c_cmd cmd;
  };
-int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id);
+int atmel_i2c_probe(struct i2c_client *client);
void atmel_i2c_enqueue(struct atmel_i2c_work_data *work_data,
  		       void (*cbk)(struct atmel_i2c_work_data *work_data,
diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
index 272a06f0b588..4403dbb0f0b1 100644
--- a/drivers/crypto/atmel-sha204a.c
+++ b/drivers/crypto/atmel-sha204a.c
@@ -93,11 +93,10 @@ static int atmel_sha204a_rng_read(struct hwrng *rng, void *data, size_t max,
static int atmel_sha204a_probe(struct i2c_client *client)
  {
-	const struct i2c_device_id *id = i2c_client_get_device_id(client);
  	struct atmel_i2c_client_priv *i2c_priv;
  	int ret;
- ret = atmel_i2c_probe(client, id);
+	ret = atmel_i2c_probe(client);
  	if (ret)
  		return ret;
base-commit: f160a0e64f0f80a82f797ea7aa007e41ba8ed441



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux