RE: [PATCH net-next v5 2/4] net: devlink: remove devlink_info_driver_name_put()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Vincent Mailhol <vincent.mailhol@xxxxxxxxx> On Behalf Of Vincent
> Mailhol
> Sent: Monday, November 28, 2022 4:06 PM
> To: Jiri Pirko <jiri@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; Jakub Kicinski
> <kuba@xxxxxxxxxx>
> Cc: David S . Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; Boris Brezillon <bbrezillon@xxxxxxxxxx>; Arnaud Ebalard
> <arno@xxxxxxxxxxxx>; Srujana Challa <schalla@xxxxxxxxxxx>; Kurt Kanzenbach
> <kurt@xxxxxxxxxxxxx>; Andrew Lunn <andrew@xxxxxxx>; Florian Fainelli
> <f.fainelli@xxxxxxxxx>; Vladimir Oltean <olteanv@xxxxxxxxx>; Michael Chan
> <michael.chan@xxxxxxxxxxxx>; Ioana Ciornei <ioana.ciornei@xxxxxxx>;
> Dimitris Michailidis <dmichail@xxxxxxxxxxxx>; Yisen Zhuang
> <yisen.zhuang@xxxxxxxxxx>; Salil Mehta <salil.mehta@xxxxxxxxxx>;
> Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; Sunil Goutham <sgoutham@xxxxxxxxxxx>; Linu
> Cherian <lcherian@xxxxxxxxxxx>; Geetha sowjanya <gakula@xxxxxxxxxxx>;
> Jerin Jacob <jerinj@xxxxxxxxxxx>; hariprasad <hkelam@xxxxxxxxxxx>;
> Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>; Taras Chornyi
> <tchornyi@xxxxxxxxxxx>; Saeed Mahameed <saeedm@xxxxxxxxxx>; Leon
> Romanovsky <leon@xxxxxxxxxx>; Ido Schimmel <idosch@xxxxxxxxxx>; Petr
> Machata <petrm@xxxxxxxxxx>; Simon Horman <simon.horman@xxxxxxxxxxxx>;
> Shannon Nelson <snelson@xxxxxxxxxxx>; drivers@xxxxxxxxxxx; Ariel Elior
> <aelior@xxxxxxxxxxx>; Manish Chopra <manishc@xxxxxxxxxxx>; Jonathan
> Lemon <jonathan.lemon@xxxxxxxxx>; Vadim Fedorenko <vadfed@xxxxxx>;
> Richard Cochran <richardcochran@xxxxxxxxx>; Vadim Pasternak
> <vadimp@xxxxxxxxxxxx>; Shalom Toledo <shalomt@xxxxxxxxxxxx>; linux-
> crypto@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; linux-
> rdma@xxxxxxxxxxxxxxx; oss-drivers@xxxxxxxxxxxx; Jiri Pirko
> <jiri@xxxxxxxxxxxx>; Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; Hao Chen
> <chenhao288@xxxxxxxxxxxxx>; Guangbin Huang
> <huangguangbin2@xxxxxxxxxx>; Minghao Chi <chi.minghao@xxxxxxxxxx>;
> Shijith Thotton <sthotton@xxxxxxxxxxx>; Vincent Mailhol
> <mailhol.vincent@xxxxxxxxxx>
> Subject: [PATCH net-next v5 2/4] net: devlink: remove
> devlink_info_driver_name_put()
> 
> Now that the core sets the driver name attribute, drivers are not
> supposed to call devlink_info_driver_name_put() anymore. Remove it.
> 

You could combine this patch with the previous one so that in the event of a cherry-pick its not possible to have this function while the core inserts the driver name automatically.

I think that also makes it very clear that there are no remaining in-tree drivers still calling the function.

I don't have a strong preference if we prefer it being separated.

Thanks,
Jake





[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux