Hi Elliott,
> 2022年8月25日 上午12:24，Elliott, Robert (Servers) <elliott@xxxxxxx> 写道：
>
>
>
>> -----Original Message-----
>> From: 'Guanjun' <guanjun@xxxxxxxxxxxxxxxxx>
>> Sent: Wednesday, August 24, 2022 4:50 AM
>> Subject: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
>>
> ...
>
>> +static struct skcipher_alg ycc_skciphers[] = {
>> + {
>> + .base = {
>> + .cra_name = "cbc(aes)",
>> + .cra_driver_name = "ycc_cbc(aes)",
>
> In comparison, the aead driver puts the hardware driver name as a suffix,
> not a prefix, and uses dashes rather than underscores and parenthesis:
>> + .cra_name = "gcm(aes)",
>> + .cra_driver_name = "gcm-aes-ycc",
>
> and the pk driver uses a prefix with a dash:
>> + .cra_name = "rsa",
>> + .cra_driver_name = "ycc-rsa",
>
> Although the existing drivers are wildly inconsistent, it would be nice
> if this driver was at least consistent with itself. Suffixes with dashes
> seem to be the most popular, so consider these formats:
> cbc-aes-ycc
> gcm-aes-ycc
> rsa-ycc
>
Thanks for your comments. I will change these names as your suggestion in next version.
Best regards,
Guanjun
