Hi Elliott, Thanks for your comments. > 2022年8月24日 下午10:57，Elliott, Robert (Servers) <elliott@xxxxxxx> 写道： > > > >> -----Original Message----- >> From: 'Guanjun' <guanjun@xxxxxxxxxxxxxxxxx> >> Sent: Wednesday, August 24, 2022 4:50 AM >> To: herbert@xxxxxxxxxxxxxxxxxxx >> Subject: [PATCH v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex) >> accelerator driver >> > ... >> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig >> index 3e6aa31..d739354 100644 >> --- a/drivers/crypto/Kconfig >> +++ b/drivers/crypto/Kconfig >> @@ -799,6 +799,8 @@ source "drivers/crypto/hisilicon/Kconfig" >> >> source "drivers/crypto/amlogic/Kconfig" >> >> +source "drivers/crypto/ycc/Kconfig" >> + >> config CRYPTO_DEV_SA2UL >> tristate "Support for TI security accelerator" >> depends on ARCH_K3 || COMPILE_TEST > > This menu isn't perfectly sorted, but since the new entry is for > "Alibaba YCC", putting this at the top of the file would be > better positioned for eventual sorting. > > Naming the directory alibaba/ rather than ycc/ might be more > welcoming for future drivers, too. Alibaba and T-Head (a semiconductor chip business entity of Alibaba Group) combined efforts on the platform Yitian, so our cryptographic accelerator which is integrated in Yitian was named YCC, the acronym for Yitian Cryptography Complex. We prefer ycc for our crypto related drivers. Anyway, thanks for your suggestions. I will adjust in alphabetical order in next version. Best regards, Guanjun > > ... >> diff --git a/drivers/crypto/ycc/Kconfig b/drivers/crypto/ycc/Kconfig >> +++ b/drivers/crypto/ycc/Kconfig >> @@ -0,0 +1,8 @@ >> +config CRYPTO_DEV_YCC >> + tristate "Support for Alibaba YCC cryptographic accelerator" >> + depends on CRYPTO && CRYPTO_HW && PCI >> + default n >> + help >> + Enables the driver for the on-chip cryptographic accelerator of >> + Alibaba Yitian SoCs which is based on ARMv9 architecture. >> + If unsure say N. >
