> On 29/06/2022 09:59, Neal Liu wrote: > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >> Sent: Wednesday, June 29, 2022 1:58 PM > >> To: Neal Liu <neal_liu@xxxxxxxxxxxxxx>; Corentin Labbe > >> <clabbe.montjoie@xxxxxxxxx>; Christophe JAILLET > >> <christophe.jaillet@xxxxxxxxxx>; Randy Dunlap > >> <rdunlap@xxxxxxxxxxxxx>; Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; > >> David S . Miller <davem@xxxxxxxxxxxxx>; Rob Herring > >> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski > >> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; > >> Andrew Jeffery <andrew@xxxxxxxx>; Dhananjay Phadke > >> <dhphadke@xxxxxxxxxxxxx>; Johnny Huang > <johnny_huang@xxxxxxxxxxxxxx> > >> Cc: linux-aspeed@xxxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; > >> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > >> linux-kernel@xxxxxxxxxxxxxxx; BMC-SW <BMC-SW@xxxxxxxxxxxxxx> > >> Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 > >> HACE reset definition > >> > >> On 29/06/2022 05:20, Neal Liu wrote: > >>> Add HACE reset bit definition for AST2500/AST2600. > >>> > >>> Signed-off-by: Neal Liu <neal_liu@xxxxxxxxxxxxxx> > >>> Signed-off-by: Johnny Huang <johnny_huang@xxxxxxxxxxxxxx> > >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>> --- > >>> include/dt-bindings/clock/aspeed-clock.h | 3 ++- > >>> include/dt-bindings/clock/ast2600-clock.h | 1 + > >>> 2 files changed, 3 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/include/dt-bindings/clock/aspeed-clock.h > >>> b/include/dt-bindings/clock/aspeed-clock.h > >>> index 9ff4f6e4558c..6e040f7c3426 100644 > >>> --- a/include/dt-bindings/clock/aspeed-clock.h > >>> +++ b/include/dt-bindings/clock/aspeed-clock.h > >>> @@ -46,11 +46,12 @@ > >>> #define ASPEED_RESET_MCTP 1 > >>> #define ASPEED_RESET_ADC 2 > >>> #define ASPEED_RESET_JTAG_MASTER 3 > >>> -#define ASPEED_RESET_MIC 4 > >>> +#define ASPEED_RESET_HACE 4 > >> > >> I did not ack such change. This is a significant change from previous > >> version, invalidating my previous ack. > >> > >> This breaks the ABI, so NAK without proper explanation why ABI break > >> is accepted. > > > > I changed the original define (MIC) into different value (see below diff), and > add a new define for HACE. > > How does that break the ABI? I'll be appreciated if you can explain it more > details. > > And sorry for not remove ack with new change. > > Yes, this breaks ABI. Previously the ASPEED_RESET_MIC define had value of 4, > now it has value of something else. Got your point. I'll re-define HACE without modifying ABI. Thanks for your suggestion.
