On Sat, May 28, 2022 at 12:24:29PM +0200, Jason A. Donenfeld wrote:
> This is used by code that doesn't need CONFIG_CRYPTO, so move this into
> lib/ with a Kconfig option so that it can be selected by whatever needs
> it.
>
> This fixes a linker error Zheng pointed out when
> CRYPTO_MANAGER_DISABLE_TESTS!=y and CRYPTO=m:
>
> lib/crypto/curve25519-selftest.o: In function `curve25519_selftest':
> curve25519-selftest.c:(.init.text+0x60): undefined reference to `__crypto_memneq'
> curve25519-selftest.c:(.init.text+0xec): undefined reference to `__crypto_memneq'
> curve25519-selftest.c:(.init.text+0x114): undefined reference to `__crypto_memneq'
> curve25519-selftest.c:(.init.text+0x154): undefined reference to `__crypto_memneq'
>
> Reported-by: Zheng Bin <zhengbin13@xxxxxxxxxx>
> Cc: Eric Biggers <ebiggers@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: aa127963f1ca ("crypto: lib/curve25519 - re-add selftests")
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> ---
> I'm traveling over the next week, and there are a few ways to skin this
> cat, so if somebody here sees issue, feel free to pick this v1 up and
> fashion a v2 out of it.
>
> crypto/Kconfig | 1 +
> crypto/Makefile | 2 +-
> lib/Kconfig | 3 +++
> lib/Makefile | 1 +
> lib/crypto/Kconfig | 1 +
> {crypto => lib}/memneq.c | 0
> 6 files changed, 7 insertions(+), 1 deletion(-)
> rename {crypto => lib}/memneq.c (100%)
Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx>
- Eric
