On Wed 2022-05-18 11:56:58, Jason A. Donenfeld wrote: > The register_random_ready_notifier() notifier is somewhat complicated, > and was already recently rewritten to use notifier blocks. It is only > used now by one consumer in the kernel, vsprintf.c, for which the async > mechanism is really overly complex for what it actually needs. This > commit removes register_random_ready_notifier() and unregister_random_ > ready_notifier(), because it just adds complication with little utility, > and changes vsprintf.c to just check on `!rng_is_initialized() && > !rng_has_arch_random()`, which will eventually be true. Performance- > wise, that code was already using a static branch, so there's basically > no overhead at all to this change. > > Cc: Petr Mladek <pmladek@xxxxxxxx> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> > Cc: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> > Acked-by: Petr Mladek <pmladek@xxxxxxxx> # for vsprintf.c > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> > --- > Changes v1->v2: > - Use a trylock instead of a spinlock to be NMI safe. Looks good to me. My ack is already there. Feel free to use: Reviewed-by: Petr Mladek <pmladek@xxxxxxxx> if you would prefer it. Thanks a lot for updating the patch. Best Regards, Petr
