Re: [PATCH] crypto: atmel - Avoid flush_scheduled_work() usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 29, 2022 at 03:26:07PM +0900, Tetsuo Handa wrote:
>
> Since drivers/crypto/Makefile has lines in
> 
> obj-$(CONFIG_CRYPTO_DEV_ATMEL_I2C) += atmel-i2c.o
> obj-$(CONFIG_CRYPTO_DEV_ATMEL_ECC) += atmel-ecc.o
> obj-$(CONFIG_CRYPTO_DEV_ATMEL_SHA204A) += atmel-sha204a.o
> 
> order (which will be used as link order for built-in.o), module_init()
> is processed in this order. Also, module_exit() is no-op if built-in.
> Therefore, I think there is no need to explicitly boost the priority
> of atmel_i2c_init().

If we're going to rely on the Makefile ordering please make it
explicit and add a comment in the Makefile.  Otherwise this is way
too fragile.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux