On 2022/04/29 14:30, Herbert Xu wrote: > On Wed, Apr 20, 2022 at 10:27:11AM +0900, Tetsuo Handa wrote: >> >> +module_init(atmel_i2c_init); >> +module_exit(atmel_i2c_exit); > > What if everything is built-in? Shouldn't this be moved to a place > earlier than module_init? Since drivers/crypto/Makefile has lines in obj-$(CONFIG_CRYPTO_DEV_ATMEL_I2C) += atmel-i2c.o obj-$(CONFIG_CRYPTO_DEV_ATMEL_ECC) += atmel-ecc.o obj-$(CONFIG_CRYPTO_DEV_ATMEL_SHA204A) += atmel-sha204a.o order (which will be used as link order for built-in.o), module_init() is processed in this order. Also, module_exit() is no-op if built-in. Therefore, I think there is no need to explicitly boost the priority of atmel_i2c_init().
