Hi Jason,
On 3/12/22 7:03 AM, Jason A. Donenfeld wrote:
Hi Tianjia,
On Wed, Mar 2, 2022 at 3:23 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
On Wed, Mar 02, 2022 at 01:26:13AM +0100, Jason A. Donenfeld wrote:
On Wed, Mar 2, 2022 at 1:24 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
On Tue, Mar 01, 2022 at 11:34:28AM +0100, Jason A. Donenfeld wrote:
lib/crypto/Kconfig | 3 +
lib/crypto/Makefile | 3 +
lib/crypto/sm4.c | 184 +++++++++++++++++++++++++++++++++++++++++++
If this is only used by the crypto API, it does not belong in
lib/crypto.
Nope there is no such rule. lib/crypto is fine if you're adding
code that is shared between crypto and arch/*/crypto.
The sprawling madness continues then... Noted.
I think it would make more sense for this code to be in crypto/, for the reason
that Jason gave.
Were you planning on submitting a patch for this?
Thanks,
Jason
I agree with Herbert that this is not necessary and the community is
currently not in agreement on this point, and I'd be happy to do the
work if there's a more reasonable reason.
Thanks so much for your suggestion.
Best regards,
Tianjia
