On Tue, Mar 01, 2022 at 11:34:28AM +0100, Jason A. Donenfeld wrote: > > lib/crypto/Kconfig | 3 + > > lib/crypto/Makefile | 3 + > > lib/crypto/sm4.c | 184 +++++++++++++++++++++++++++++++++++++++++++ > > If this is only used by the crypto API, it does not belong in > lib/crypto. Nope there is no such rule. lib/crypto is fine if you're adding code that is shared between crypto and arch/*/crypto. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt