On Tue, Mar 1, 2022 at 2:22 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > You additional export symbols of those SIMD implementations in > arch/crypto/, which is not correct either, since nothing in the tree > uses those symbols. Please remove those EXPORT_SYMBOL directives as > well. Those functions can be static, and do not need to be declared in > the .h file. Actually, this part isn't quite so, because you share the avx implementation in the avx2 implementation. However, > Yes, and those accelerated implementations are part of the crypto API, > and are not used by anything except the crypto API. Hence this should > be in crypto/, just like everything else that is /only/ used for the > cryto API. lib/crypto/ is for in-kernel users of crypto via normal > code paths. sm4.c does not belong in lib/crypto/ and should be moved. This still holds. Jason
