On Fri, Feb 25, 2022 at 05:05:09PM +0100, Christoph Hellwig wrote: > On Tue, Feb 22, 2022 at 08:31:41AM -0800, Keith Busch wrote: > > Provide a module to test the rocksoft crc64 calculations with well known > > inputs and exepected values. Check the generic table implementation and > > whatever module is registered from the crypto library, and compare their > > speeds. > > The code looks good, but isn't the trent to use the kunit framework > for these kinds of tests these days? I don't have experience with kunit, but I'll look into that. I am already changing the way this gets tested. Eric recommended adding to the crypto "testmgr", and I've done that on my private tree. That test framework exercises a lot more than this this patch, and it did reveal a problem with how I've implemented the initial XOR when the buffer is split, so I have some minor updates coming soon.
