The NVM Express protocol added enhancements to the data integrity field formats beyond the T10 defined protection information. A detailed description of the new formats can be found in the NVMe's NVM Command Set Specification, section 5.2, available at: https://nvmexpress.org/wp-content/uploads/NVM-Command-Set-Specification-1.0b-2021.12.18-Ratified.pdf This series implements one possible new format: the CRC64 guard with 48-bit reference tags. This does not add support for the variable "storage tag" field, or any potential hardware acceleration. Changes since v2: Introduced lower_48_bits() (Bart) Added "64" suffix to crc names to distinguish from other crc calculations (Martin) Added module support to crypto library, and have the integrity generate/verify use that instead of directly calling the generic table lookup implementation. This is modeled after the t10 implementation. Added an x86 pclmul accelerated crc64 calculation Added speed tests to the test module so that the generic and library function could be compared. Bug fix in nvme to select the correct integrity profile. Added reviews Note, I am not particularly well versed with x86 assembly, so I'm reasonably sure that the pcl implementation could be improved. It currently is about 20x faster than the generic implementation, but I believe it could be over 30x faster if done more efficiently. Keith Busch (10): block: support pi with extended metadata nvme: allow integrity on extended metadata formats asm-generic: introduce be48 unaligned accessors linux/kernel: introduce lower_48_bits macro lib: add rocksoft model crc64 crypto: add rocksoft 64b crc guard tag framework lib: add crc64 tests block: add pi for nvme enhanced integrity nvme: add support for enhanced metadata x86/crypto: add pclmul acceleration for crc64 arch/x86/crypto/Makefile | 3 + arch/x86/crypto/crc64-rocksoft-pcl-asm.S | 215 ++++++++++++++++++++++ arch/x86/crypto/crc64-rocksoft-pcl_glue.c | 117 ++++++++++++ block/Kconfig | 1 + block/bio-integrity.c | 1 + block/t10-pi.c | 198 +++++++++++++++++++- crypto/Kconfig | 20 ++ crypto/Makefile | 1 + crypto/crc64_rocksoft_generic.c | 104 +++++++++++ drivers/nvme/host/core.c | 175 ++++++++++++++---- drivers/nvme/host/nvme.h | 4 +- include/asm-generic/unaligned.h | 26 +++ include/linux/blk-integrity.h | 1 + include/linux/crc64.h | 7 + include/linux/kernel.h | 6 + include/linux/nvme.h | 53 +++++- include/linux/t10-pi.h | 20 ++ lib/Kconfig | 9 + lib/Kconfig.debug | 4 + lib/Makefile | 2 + lib/crc64-rocksoft.c | 129 +++++++++++++ lib/crc64.c | 26 +++ lib/gen_crc64table.c | 51 +++-- lib/test_crc64.c | 133 +++++++++++++ 24 files changed, 1252 insertions(+), 54 deletions(-) create mode 100644 arch/x86/crypto/crc64-rocksoft-pcl-asm.S create mode 100644 arch/x86/crypto/crc64-rocksoft-pcl_glue.c create mode 100644 crypto/crc64_rocksoft_generic.c create mode 100644 lib/crc64-rocksoft.c create mode 100644 lib/test_crc64.c -- 2.25.4
