On Tue, Feb 22, 2022 at 11:50:44AM -0800, Eric Biggers wrote: > > +config CRC64_ROCKSOFT > > + tristate "CRC calculation for the Rocksoft^TM model CRC64" > > I'm sure what the rules for trademarks are, but kernel source code usually > doesn't have the trademark symbol/abbreviation scattered everywhere. > > > + select CRYPTO > > + select CRYPTO_CRC64_ROCKSOFT > > + help > > + This option is only needed if a module that's not in the > > + kernel tree needs to calculate CRC checks for use with the > > + rocksoft model parameters. > > Out-of-tree modules can't be the reason to have a kconfig option. What is the > real reason? Also this option can be enabled without the CONFIG_CRC64 it depends on, which is broken. - Eric
