On Wed, Feb 9, 2022 at 9:31 AM Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> wrote: > Looks good generally, just one unrelated change slipped in: > > > bytes = min(count, sizeof(buf)); > > - if (copy_from_user(&buf, p, bytes)) > > + if (copy_from_user(buf, p, bytes)) > > return -EFAULT; I'll often fix up very minor adjacent code style things. In this case, `buf` is an array, so the code is equivalent, but I prefer the latter, which is mostly what's used throughout the driver. Jason
