Hi Ard, On Tue, Dec 14, 2021 at 6:23 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > Could we separate the whitespace-only changes from the code changes > please? Otherwise, this is really hard to review. Grr, not so easily, unfortunately. It was really a mistake that the original one wasn't clang-formatted for some level of determinism like this one is. As Mathias mentioned, --color-words -w makes it a lot more clear what's going on. But actually, even with whitespace unchanged, there's a *lot* of change in this patch because the register allocation changed, so lots of %1 became %0 and suchlike. It's probably easier to just look at https://github.com/project-everest/hacl-star/commit/a9f1c5fa440b7e95e3d853671ee65b31ee5c473b to see what's changed. Alternatively, if you don't want to review this, that's fine -- just say so -- and Herbert can go with Mathias' Reviewed-by, which might make sense anyway because he spent a lot of time with this code. Jason
