Am 14.12.21 um 18:23 schrieb Ard Biesheuvel: > On Tue, 14 Dec 2021 at 17:02, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: >> >> Rather than passing all variables as modified, pass ones that are only >> read into that parameter. This helps with old gcc versions when >> alternatives are additionally used, and lets gcc's codegen be a little >> bit more efficient. This also syncs up with the latest Vale/EverCrypt >> output. >> >> Reported-by: Mathias Krause <minipli@xxxxxxxxxxxxxx> >> Cc: Aymeric Fromherz <aymeric.fromherz@xxxxxxxx> >> Link: https://lore.kernel.org/wireguard/1554725710.1290070.1639240504281.JavaMail.zimbra@xxxxxxxx/ >> Link: https://github.com/project-everest/hacl-star/pull/501 >> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> > > Could we separate the whitespace-only changes from the code changes > please? Otherwise, this is really hard to review. > Applying the patch and using `git show --color-words -w` helped me to lower the noise ratio to a sensible level. Mathias
