On Mon, Nov 15, 2021 at 09:40:57AM -0800, Peter Gonda wrote:
> SEV_INIT requires users to unlock their SPI bus for the PSP's non
> volatile (NV) storage. Users may wish to lock their SPI bus for numerous
> reasons, to support this the PSP firmware supports SEV_INIT_EX. INIT_EX
> allows the firmware to use a region of memory for its NV storage leaving
> the kernel responsible for actually storing the data in a persistent
> way. This series adds a new module parameter to ccp allowing users to
> specify a path to a file for use as the PSP's NV storage. The ccp driver
> then reads the file into memory for the PSP to use and is responsible
> for writing the file whenever the PSP modifies the memory region.
>
> V3
> * Add another module parameter 'psp_init_on_probe' to allow for skipping
> PSP init on module init.
> * Fixes review comments from Sean.
> * Fixes missing error checking with file reading.
> * Removed setting 'error' to a set value in patch 1.
This doesn't compile cleanly for me with C=1 W=1:
CC [M] drivers/crypto/ccp/sev-dev.o
In file included from ../arch/x86/include/asm/bug.h:84,
from ../include/linux/bug.h:5,
from ../include/linux/cpumask.h:14,
from ../arch/x86/include/asm/cpumask.h:5,
from ../arch/x86/include/asm/msr.h:11,
from ../arch/x86/include/asm/processor.h:22,
from ../arch/x86/include/asm/timex.h:5,
from ../include/linux/timex.h:65,
from ../include/linux/time32.h:13,
from ../include/linux/time.h:60,
from ../include/linux/stat.h:19,
from ../include/linux/module.h:13,
from ../drivers/crypto/ccp/sev-dev.c:10:
../drivers/crypto/ccp/sev-dev.c: In function ‘sev_read_init_ex_file’:
../include/linux/lockdep.h:286:52: error: invalid type argument of ‘->’ (have ‘struct mutex’)
#define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
^~
Please fix and resubmit.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
