On Mon, Aug 16, 2021 at 9:21 PM Dongliang Mu <mudongliangabcd@xxxxxxxxx> wrote: > > On Thu, Aug 12, 2021 at 6:43 PM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Thu, Aug 12, 2021 at 06:40:20PM +0800, Dongliang Mu wrote: > > > > > > I agree with you and would like to modify "return 0" to "return err" > > > in the next version. Even if the parent function does not care about > > > the return value, it is still necessary to keep the right return > > > value. > > > > Well if the parent is ignoring the error then returning the error > > there obviously isn't going to help. > > If so, do I still need to change my current patch? Any update on this thread? > > Dongliang Mu > > > > > Cheers, > > -- > > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > Home Page: http://gondor.apana.org.au/~herbert/ > > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
