On Thu, Aug 12, 2021 at 6:05 PM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Aug 03, 2021 at 02:31:38PM +0800, Dongliang Mu wrote: > > > > -theend: > > - kfree(buf); > > +err_result: > > kfree(result); > > - crypto_finalize_hash_request(engine, breq, err); > > +err_buf: > > + kfree(buf); > > +out: > > + if (!err) > > + crypto_finalize_hash_request(engine, breq, err); > > return 0; > > This does not look right. You're returning zero in case of an error Hi Herbert, Corentin Labbe said, For the error code, I am not sure it is needed, error code is already given to user via crypto_finalize_hash_request(). The "return 0" is for crypto/crypto_engine API, returning an error will not change anything since we dont have retry_support. So I propose you to focus on dma_map_xxx() fix patch. See details in [1]. P.S., my previous patch returns err variable. [1] https://lkml.org/lkml/2021/7/26/164 > > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
