On Fri, 20 Nov 2020 at 11:09, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Fri, Nov 20, 2020 at 10:24:44AM +0100, Ard Biesheuvel wrote: > > > > OK, I'll apply this on top > > > > diff --git a/crypto/Kconfig b/crypto/Kconfig > > index 9ff2d687e334..959ee48f66a8 100644 > > --- a/crypto/Kconfig > > +++ b/crypto/Kconfig > > @@ -202,7 +202,7 @@ config CRYPTO_AUTHENC > > config CRYPTO_TEST > > tristate "Testing module" > > depends on m || CRYPTO_MANAGER_EXTRA_TESTS > > - select CRYPTO_MANAGER > > + depends on CRYPTO_MANAGER > > How about just removing the depends line altogether? > That may break the build, and therefore randconfig build testing: crypto/tcrypt.o: In function `do_mult_aead_op': tcrypt.c:(.text+0x180): undefined reference to `crypto_aead_encrypt' tcrypt.c:(.text+0x194): undefined reference to `crypto_aead_decrypt' crypto/tcrypt.o: In function `do_mult_acipher_op': tcrypt.c:(.text+0x2a0): undefined reference to `crypto_skcipher_encrypt' tcrypt.c:(.text+0x2b4): undefined reference to `crypto_skcipher_decrypt' crypto/tcrypt.o: In function `test_skcipher_speed': tcrypt.c:(.text+0xf60): undefined reference to `crypto_alloc_skcipher' tcrypt.c:(.text+0x1088): undefined reference to `crypto_skcipher_setkey' tcrypt.c:(.text+0x1534): undefined reference to `crypto_skcipher_encrypt' tcrypt.c:(.text+0x1570): undefined reference to `crypto_skcipher_decrypt' tcrypt.c:(.text+0x15e8): undefined reference to `crypto_skcipher_encrypt' tcrypt.c:(.text+0x1624): undefined reference to `crypto_skcipher_decrypt' tcrypt.c:(.text+0x168c): undefined reference to `crypto_skcipher_encrypt' tcrypt.c:(.text+0x16a8): undefined reference to `crypto_skcipher_decrypt' crypto/tcrypt.o: In function `test_mb_aead_speed.constprop.23': tcrypt.c:(.text+0x2020): undefined reference to `crypto_alloc_aead' tcrypt.c:(.text+0x2048): undefined reference to `crypto_aead_setauthsize' tcrypt.c:(.text+0x23a4): undefined reference to `crypto_aead_setkey' tcrypt.c:(.text+0x27d0): undefined reference to `crypto_aead_encrypt' crypto/tcrypt.o: In function `test_mb_skcipher_speed': tcrypt.c:(.text+0x28ec): undefined reference to `crypto_alloc_skcipher' tcrypt.c:(.text+0x2c08): undefined reference to `crypto_skcipher_setkey' crypto/tcrypt.o: In function `test_aead_speed.constprop.22': tcrypt.c:(.text+0x320c): undefined reference to `crypto_alloc_aead' tcrypt.c:(.text+0x331c): undefined reference to `crypto_aead_setkey' tcrypt.c:(.text+0x3328): undefined reference to `crypto_aead_setauthsize' tcrypt.c:(.text+0x33ec): undefined reference to `crypto_aead_encrypt' tcrypt.c:(.text+0x3428): undefined reference to `crypto_aead_decrypt' tcrypt.c:(.text+0x3488): undefined reference to `crypto_aead_encrypt' tcrypt.c:(.text+0x34c4): undefined reference to `crypto_aead_decrypt' tcrypt.c:(.text+0x3528): undefined reference to `crypto_aead_encrypt' tcrypt.c:(.text+0x3564): undefined reference to `crypto_aead_decrypt' tcrypt.c:(.text+0x3744): undefined reference to `crypto_aead_encrypt' crypto/tcrypt.o: In function `do_test': tcrypt.c:(.text+0x3ad0): undefined reference to `alg_test' tcrypt.c:(.text+0x3af4): undefined reference to `alg_test' tcrypt.c:(.text+0x3b18): undefined reference to `alg_test' tcrypt.c:(.text+0x3b34): undefined reference to `alg_test' tcrypt.c:(.text+0x3b50): undefined reference to `alg_test'
