On Mon, Nov 09, 2020 at 09:31:42AM +0100, Ard Biesheuvel wrote: > When working on crypto algorithms, being able to run tcrypt quickly > without booting an entire Linux installation can be very useful. For > instance, QEMU/kvm can be used to boot a kernel from the command line, > and having tcrypt.ko builtin would allow tcrypt to be executed to run > benchmarks, or to run tests for algortithms that need to be instantiated > from templates, without the need to make it past the point where the > rootfs is mounted. > > So let's relax the requirement that tcrypt can only be built as a > module when CRYPTO_MANAGER_EXTRA_TESTS is enabled, as this is already > documented as a crypto development-only symbol. > > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx> > --- > crypto/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 094ef56ab7b4..9ff2d687e334 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -201,7 +201,7 @@ config CRYPTO_AUTHENC > > config CRYPTO_TEST > tristate "Testing module" > - depends on m > + depends on m || CRYPTO_MANAGER_EXTRA_TESTS > select CRYPTO_MANAGER > help > Quick & dirty crypto test module. This breaks the build: crypto/Kconfig:150:error: recursive dependency detected! crypto/Kconfig:150: symbol CRYPTO_MANAGER_EXTRA_TESTS depends on CRYPTO_MANAGER crypto/Kconfig:119: symbol CRYPTO_MANAGER is selected by CRYPTO_TEST crypto/Kconfig:206: symbol CRYPTO_TEST depends on CRYPTO_MANAGER_EXTRA_TESTS For a resolution refer to Documentation/kbuild/kconfig-language.rst subsection "Kconfig recursive dependency limitations" Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt