Re: [PATCH v4 16/17] crypto: sun8i-ce: fix comparison of integer expressions of different signedness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 21, 2020 at 02:32:15PM -0700, Joe Perches wrote:
> On Tue, 2020-07-21 at 19:06 +0000, Corentin Labbe wrote:
> > This patch fixes the warning:
> > warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
> 
> I think these do not really need conversion.
> Are these useful compiler warnings ?
> 

Since ARRAY_SIZE(ce_algs) will never greater than MAX(int), the conversion does not fix a bug.
But at least the code is more proper.
So I think the patch is still usefull.




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux