On Tue, 2020-07-21 at 19:06 +0000, Corentin Labbe wrote:
> This patch fixes the warning:
> warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
I think these do not really need conversion.
Are these useful compiler warnings ?
> Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> index 3901e3401c6b..7b2a142c9b8d 100644
> --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> @@ -566,7 +566,7 @@ static struct sun8i_ce_alg_template ce_algs[] = {
> static int sun8i_ce_dbgfs_read(struct seq_file *seq, void *v)
> {
> struct sun8i_ce_dev *ce = seq->private;
> - int i;
> + unsigned int i;
>
> for (i = 0; i < MAXFLOW; i++)
> seq_printf(seq, "Channel %d: nreq %lu\n", i, ce->chanlist[i].stat_req);
> @@ -778,7 +778,8 @@ static int sun8i_ce_get_clks(struct sun8i_ce_dev *ce)
>
> static int sun8i_ce_register_algs(struct sun8i_ce_dev *ce)
> {
> - int ce_method, err, id, i;
> + int ce_method, err, id;
> + unsigned int i;
>
> for (i = 0; i < ARRAY_SIZE(ce_algs); i++) {
> ce_algs[i].ce = ce;
> @@ -858,7 +859,7 @@ static int sun8i_ce_register_algs(struct sun8i_ce_dev *ce)
>
> static void sun8i_ce_unregister_algs(struct sun8i_ce_dev *ce)
> {
> - int i;
> + unsigned int i;
>
> for (i = 0; i < ARRAY_SIZE(ce_algs); i++) {
> if (!ce_algs[i].ce)
