Re: [PATCHv5 2/7] crypto: sa2ul: Add crypto driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 09, 2020 at 06:03:01PM +1000, Herbert Xu wrote:
> On Wed, Jul 01, 2020 at 11:05:48AM +0300, Tero Kristo wrote:
> > From: Keerthy <j-keerthy@xxxxxx>
> > 
> > Adds a basic crypto driver and currently supports AES/3DES
> > in cbc mode for both encryption and decryption.
> > 
> > Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> > [t-kristo@xxxxxx: major re-work to fix various bugs in the driver and to
> >  cleanup the code]
> > Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
> > ---
> >  drivers/crypto/Kconfig  |   14 +
> >  drivers/crypto/Makefile |    1 +
> >  drivers/crypto/sa2ul.c  | 1391 +++++++++++++++++++++++++++++++++++++++
> >  drivers/crypto/sa2ul.h  |  380 +++++++++++
> >  4 files changed, 1786 insertions(+)
> >  create mode 100644 drivers/crypto/sa2ul.c
> >  create mode 100644 drivers/crypto/sa2ul.h
> 
> I get lots of sparse warnings with this driver.  Please fix them
> and resubmit.

Please also compile test with W=1.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux