On Wed, Jul 01, 2020 at 11:05:48AM +0300, Tero Kristo wrote: > From: Keerthy <j-keerthy@xxxxxx> > > Adds a basic crypto driver and currently supports AES/3DES > in cbc mode for both encryption and decryption. > > Signed-off-by: Keerthy <j-keerthy@xxxxxx> > [t-kristo@xxxxxx: major re-work to fix various bugs in the driver and to > cleanup the code] > Signed-off-by: Tero Kristo <t-kristo@xxxxxx> > --- > drivers/crypto/Kconfig | 14 + > drivers/crypto/Makefile | 1 + > drivers/crypto/sa2ul.c | 1391 +++++++++++++++++++++++++++++++++++++++ > drivers/crypto/sa2ul.h | 380 +++++++++++ > 4 files changed, 1786 insertions(+) > create mode 100644 drivers/crypto/sa2ul.c > create mode 100644 drivers/crypto/sa2ul.h I get lots of sparse warnings with this driver. Please fix them and resubmit. ../drivers/crypto/sa2ul.c:402:24: warning: incorrect type in assignment (different base types) ../drivers/crypto/sa2ul.c:402:24: expected unsigned int [usertype] ../drivers/crypto/sa2ul.c:402:24: got restricted __be32 [usertype] ../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32 ../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32 ../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32 ../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32 ../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32 ../drivers/crypto/sa2ul.c:920:33: warning: missing braces around initializer ../drivers/crypto/sa2ul.c:940:33: warning: missing braces around initializer ../drivers/crypto/sa2ul.c:958:33: warning: missing braces around initializer ../drivers/crypto/sa2ul.c:972:33: warning: missing braces around initializer ../drivers/crypto/sa2ul.c:1003:35: warning: incorrect type in assignment (different base types) ../drivers/crypto/sa2ul.c:1003:35: expected unsigned int [usertype] ../drivers/crypto/sa2ul.c:1003:35: got restricted __be32 [usertype] ../drivers/crypto/sa2ul.c:628:41: warning: incorrect type in assignment (different base types) ../drivers/crypto/sa2ul.c:628:41: expected unsigned int [usertype] ../drivers/crypto/sa2ul.c:628:41: got restricted __be32 [usertype] ../drivers/crypto/sa2ul.c:528:22: warning: incorrect type in assignment (different base types) ../drivers/crypto/sa2ul.c:528:22: expected unsigned int [usertype] ../drivers/crypto/sa2ul.c:528:22: got restricted __be32 [usertype] ../drivers/crypto/sa2ul.c:1236:34: warning: Using plain integer as NULL pointer ../drivers/crypto/sa2ul.c:1310:27: warning: incorrect type in assignment (different base types) ../drivers/crypto/sa2ul.c:1310:27: expected unsigned int [usertype] ../drivers/crypto/sa2ul.c:1310:27: got restricted __be32 [usertype] ../drivers/crypto/sa2ul.c:1348:34: warning: Using plain integer as NULL pointer ../drivers/crypto/sa2ul.c:1570:33: warning: missing braces around initializer ../drivers/crypto/sa2ul.c:1586:33: warning: missing braces around initializer ../drivers/crypto/sa2ul.c:1602:33: warning: missing braces around initializer ../drivers/crypto/sa2ul.c:1658:30: warning: incorrect type in assignment (different base types) ../drivers/crypto/sa2ul.c:1658:30: expected unsigned int [usertype] ../drivers/crypto/sa2ul.c:1658:30: got restricted __be32 [usertype] ../drivers/crypto/sa2ul.c:1846:33: warning: missing braces around initializer ../drivers/crypto/sa2ul.c:1859:33: warning: missing braces around initializer ../drivers/crypto/sa2ul.c:1873:34: warning: Using plain integer as NULL pointer ../drivers/crypto/sa2ul.c:2167:6: warning: symbol 'sa_register_algos' was not declared. Should it be static? ../drivers/crypto/sa2ul.c:2199:6: warning: symbol 'sa_unregister_algos' was not declared. Should it be static? Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
