On Sat, Jun 06, 2020 at 04:25:22AM +1000, Herbert Xu wrote: > > That would make the checks for a NULL tfm in crc_t10dif_transform_show() and > > crc_t10dif_notify() unnecessary. Also, it would make it so that > > crc_t10dif_update() no longer crashes if called before module_init(). > > crc_t10dif_update can never be called prior to module_init while > the other two functions both can. > That's only guaranteed to be true if the code is built is a loadable module. If it's built-in to the kernel, it could be called earlier, by a previous initcall. Probably no one is running into this now, but it could happen in the future. - Eric
