On Fri, Jun 05, 2020 at 11:22:37AM -0700, Eric Biggers wrote: > > Wouldn't it be better to have crct10dif_fallback enabled by default, and then > disable it once the tfm is allocated? That's a semantic change. As it is if the first allocation fails then we never try again. You can do this in a different patch. > That would make the checks for a NULL tfm in crc_t10dif_transform_show() and > crc_t10dif_notify() unnecessary. Also, it would make it so that > crc_t10dif_update() no longer crashes if called before module_init(). crc_t10dif_update can never be called prior to module_init while the other two functions both can. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
